Revision: 11100
Author: [email protected]
Date: Wed Mar 21 02:23:09 2012
Log: When running with --always-opt, don't deoptimize named loads with
uninitialized type feedback.
This avoids tests taking too long because of repeated deoptimizations.
Review URL: https://chromiumcodereview.appspot.com/9812004
http://code.google.com/p/v8/source/detail?r=11100
Modified:
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Tue Mar 20 11:15:31 2012
+++ /branches/bleeding_edge/src/hydrogen.cc Wed Mar 21 02:23:09 2012
@@ -4523,7 +4523,7 @@
HInstruction* HGraphBuilder::BuildLoadNamedGeneric(HValue* obj,
Property* expr) {
- if (expr->IsUninitialized()) {
+ if (expr->IsUninitialized() && !FLAG_always_opt) {
AddInstruction(new(zone()) HSoftDeoptimize);
current_block()->MarkAsDeoptimizing();
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc Mon Mar 19
08:54:37 2012
+++ /branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc Wed Mar 21
02:23:09 2012
@@ -277,9 +277,7 @@
TEST(CFromJSStackTrace) {
// BUG(1303) Inlining of JSFuncDoTrace() in JSTrace below breaks this
test.
i::FLAG_use_inlining = false;
- // This test does not work with --always-opt because we don't replace
the code
- // in the JSFunction at deoptimization in that case.
- i::FLAG_always_opt = false;
+
TickSample sample;
InitTraceEnv(&sample);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
