LGTM if comments are addressed.
http://codereview.chromium.org/9814006/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/9814006/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4467 src/ia32/lithium-codegen-ia32.cc:4467: for (int i = 0; i < FixedArray::kHeaderSize; i += kPointerSize) { This should be FixedArrayBase::kHeaderSize (doesn't make a difference in practice because FixedArray inherits kHeaderSize from FixedArrayBase, but let's be correct here nevertheless). http://codereview.chromium.org/9814006/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4478 src/ia32/lithium-codegen-ia32.cc:4478: int64_t i_value; Remove the "i_". Just "value". The same applies to i_value_low and i_value_high below. http://codereview.chromium.org/9814006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
