https://chromiumcodereview.appspot.com/9716035/diff/1/src/api.cc File src/api.cc (right):
https://chromiumcodereview.appspot.com/9716035/diff/1/src/api.cc#newcode3069 src/api.cc:3069: i::JSObject::TransformToFastProperties(Utils::OpenHandle(this), 0); It would be nice not to have this code duplicated in api.cc and runtime.cc, but I have no suggestion how to make it cleaner ATM. https://chromiumcodereview.appspot.com/9716035/diff/1/src/objects.cc File src/objects.cc (left): https://chromiumcodereview.appspot.com/9716035/diff/1/src/objects.cc#oldcode4517 src/objects.cc:4517: bool convert_back_to_fast = HasFastProperties() && Here we only convert the object back to fast properties when it had fast properties before. With the current change we will always convert back to fast properties after defining an accessor. I am not sure this what we want. https://chromiumcodereview.appspot.com/9716035/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/9716035/diff/1/src/objects.h#newcode8054 src/objects.h:8054: Object* SafeGet(AccessorComponent component); Since there is no "unsafe" version anymore, can we just call this GetComponent() or Get()? https://chromiumcodereview.appspot.com/9716035/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9716035/diff/1/src/runtime.cc#newcode4354 src/runtime.cc:4354: JSObject::TransformToFastProperties(obj, 0); See first comment. https://chromiumcodereview.appspot.com/9716035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
