LGTM.
https://chromiumcodereview.appspot.com/9837002/diff/1017/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/9837002/diff/1017/src/ia32/lithium-codegen-ia32.cc#newcode2547 src/ia32/lithium-codegen-ia32.cc:2547: __ lea(result, Operand(esp, -2 * kPointerSize)); Maybe it would be nicer to have the result of arguments-elements point right to the start of the arguments in both cases (inlined and non-inlined), instead of having the LArgumentsAccessAt compensate for the fixed delta. https://chromiumcodereview.appspot.com/9837002/diff/1017/test/mjsunit/compiler/inline-arguments.js File test/mjsunit/compiler/inline-arguments.js (right): https://chromiumcodereview.appspot.com/9837002/diff/1017/test/mjsunit/compiler/inline-arguments.js#newcode138 test/mjsunit/compiler/inline-arguments.js:138: return toarr_inner(marker, a/2, b/2, c/2); Please also add a test where inlining happens inside an argument-expression: return foo(uninlined(0), toarr_inner(marker, a/2, b/2, c/2)); https://chromiumcodereview.appspot.com/9837002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
