Thanks everyone. I just made a small correction which was breaking xcode builds. I did test 64bits, 32bits, shared/static, gcc/clang and make/xcode combinations on Mac OS X Lion. Also verified it works on Linux as before.
Ran the unit tests, they succeed for 64bits builds but there's one failure for 32bits builds (http://friendpaste.com/ 2cBbU4F3OycXnMuqzUYI3a). This failure also happens without my patch, so I guess I can ignore it. As for Windows, I'm not familiar with Windows development nor do I have access to a Windows box. Would be very thankful if someone could test it :) Ok, I submitted a CLA and registered at http://codereview.chromium.org/. Now how do I submit the patch? I installed depot_tools, and from within a git checkout (from github.com/v8/v8) I did the following, which always gives me a timeout: fdmanana 14:50:03 ~/git/hub/v8 (osx_64bits_build)> git-cl upload Running presubmit upload checks ... Presubmit checks passed. Makefile | 2 +- build/common.gypi | 22 ++++++++++++++++++++++ build/gyp_v8 | 7 ++++++- tools/gyp/v8.gyp | 10 ++++++++-- 4 files changed, 37 insertions(+), 4 deletions(-) Upload server: http://codereview.chromium.org:443 (change with -s/-- server) Email (login for uploading to http://codereview.chromium.org:443) [fdman...@gmail.com]: Password for fdman...@gmail.com: Got exception while uploading -- saving description to /Users/ fdmanana/.git_cl_description_backup Traceback (most recent call last): File "/Users/fdmanana/git/hub/depot_tools/git_cl.py", line 1528, in <module> sys.exit(main(sys.argv[1:])) File "/Users/fdmanana/git/hub/depot_tools/git_cl.py", line 1513, in main return command(parser, argv[1:]) File "/Users/fdmanana/git/hub/depot_tools/git_cl.py", line 1087, in CMDupload return RietveldUpload(options, args, cl) File "/Users/fdmanana/git/hub/depot_tools/git_cl.py", line 999, in RietveldUpload issue, patchset = upload.RealMain(['upload'] + upload_args + args) File "/Users/fdmanana/git/hub/depot_tools/third_party/upload.py", line 2313, in RealMain response_body = rpc_server.Send("/upload", body, content_type=ctype) File "/Users/fdmanana/git/hub/depot_tools/third_party/upload.py", line 376, in Send self._Authenticate() File "/Users/fdmanana/git/hub/depot_tools/third_party/upload.py", line 421, in _Authenticate super(HttpRpcServer, self)._Authenticate() File "/Users/fdmanana/git/hub/depot_tools/third_party/upload.py", line 349, in _Authenticate self._GetAuthCookie(auth_token) File "/Users/fdmanana/git/hub/depot_tools/third_party/upload.py", line 284, in _GetAuthCookie response = self.opener.open(req) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/ python2.7/urllib2.py", line 394, in open response = self._open(req, data) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/ python2.7/urllib2.py", line 412, in _open '_open', req) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/ python2.7/urllib2.py", line 372, in _call_chain result = func(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/ python2.7/urllib2.py", line 1199, in http_open return self.do_open(httplib.HTTPConnection, req) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/ python2.7/urllib2.py", line 1174, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> fdmanana 14:51:30 ~/git/hub/v8 (osx_64bits_build)> I'm assuming this is somehow linked to my gmail account and that I should use my gmail account password. Thanks for your help. On Mar 23, 10:10 am, Jakob Kummerow <jkumme...@chromium.org> wrote: > Yay! Thanks for doing this work. > > As Yang said, please upload your patch (against the bleeding_edge branch) > to our code review site and sign the CLA. > > Before I can land this, I'll have to test: > - does it work for ia32 and x64 builds? (I guess you've verified this) > - does it work for shared and static library builds? > - does it work for all of GCC, clang, and XCode? > - does it work when V8 is embedded into Chromium? > - does the new GYP revision work fine on the other platforms (Linux, Win)? > > I currently have some other stuff to deal with, but I'll hopefully get > around to this some time next week. In the meantime, if you want to help > with the testing, that'd be great :-) > > > > > > > > On Fri, Mar 23, 2012 at 05:31, Yang Guo <yang...@chromium.org> wrote: > > Hi, > > > thanks for contributing! The best course of action would be to submit your > > patch as a change list to our code review site. Details are described here: > >http://code.google.com/p/v8/wiki/Contributing(also follow the link to > > "requesting a review") > > Please make sure to sign the CLA (electronically). For this change list I > > would suggest jkumme...@chromium.org as reviewer as he is most familiar > > with our GYP build. > > > Cheers, > > > Yang > > On Mar 23, 2012 3:25 AM, "fdmanana" <fdman...@gmail.com> wrote: > > >> Hi, > > >> I made a patch that allows to build V8 in 64bits mode for Mac OS X > >> using GYP. > >> It's referenced in the following user list thread: > > >>https://groups.google.com/group/v8-users/browse_thread/thread/4d315e1... > > >> (patch athttps://gist.github.com/2160061) > > >> What's the procedure to submit it? > > >> Thanks > > >> -- > >> v8-dev mailing list > >> v8-dev@googlegroups.com > >>http://groups.google.com/group/v8-dev > > > -- > > v8-dev mailing list > > v8-dev@googlegroups.com > >http://groups.google.com/group/v8-dev -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
