LGTM with comments.
http://codereview.chromium.org/9845019/diff/3001/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): http://codereview.chromium.org/9845019/diff/3001/src/x64/deoptimizer-x64.cc#newcode150 src/x64/deoptimizer-x64.cc:150: ASSERT_EQ(kJnsOffsetDebugCode, *(call_target_address - 2)); Whoa, this was totally non-obvious, perhaps a comment about the different code size. http://codereview.chromium.org/9845019/diff/3001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/9845019/diff/3001/src/x64/full-codegen-x64.cc#newcode364 src/x64/full-codegen-x64.cc:364: EmitProfilingCounterReset(); Perhaps you could save code size be doing this in the InterruptStub? Would make the generated code smaller. Another CL? http://codereview.chromium.org/9845019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
