https://chromiumcodereview.appspot.com/9965054/diff/1/src/heap.cc File src/heap.cc (left):
https://chromiumcodereview.appspot.com/9965054/diff/1/src/heap.cc#oldcode4821 src/heap.cc:4821: idle_notification_will_schedule_next_gc_ = true; This was the last site that changed the above flag. Can we get rid of the flag completely? https://chromiumcodereview.appspot.com/9965054/diff/1/src/incremental-marking.h File src/incremental-marking.h (right): https://chromiumcodereview.appspot.com/9965054/diff/1/src/incremental-marking.h#newcode49 src/incremental-marking.h:49: enum Finalizer { The name "finalizer" feels wrong. Can we change this to something like ... enum CompletionAction { NO_COMPLETION_ACTION, GC_VIA_STACK_GUARD }; https://chromiumcodereview.appspot.com/9965054/diff/1/src/incremental-marking.h#newcode113 src/incremental-marking.h:113: void Step(intptr_t allocated, Finalizer finalizer = GC_VIA_STACK_GUARD); There are only three other call-sites, could we get along without a default argument? https://chromiumcodereview.appspot.com/9965054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
