Revision: 11207
Author: [email protected]
Date: Mon Apr 2 06:26:05 2012
Log: Cosmetic (ARM/MIPS): Use FieldMemOperand where appropriate.
Review URL: https://chromiumcodereview.appspot.com/9963051
http://code.google.com/p/v8/source/detail?r=11207
Modified:
/branches/bleeding_edge/src/arm/stub-cache-arm.cc
/branches/bleeding_edge/src/mips/full-codegen-mips.cc
/branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc
/branches/bleeding_edge/src/mips/stub-cache-mips.cc
=======================================
--- /branches/bleeding_edge/src/arm/stub-cache-arm.cc Tue Mar 13 04:39:30
2012
+++ /branches/bleeding_edge/src/arm/stub-cache-arm.cc Mon Apr 2 06:26:05
2012
@@ -1730,7 +1730,7 @@
// We can't address the last element in one operation. Compute the more
// expensive shift first, and use an offset later on.
__ add(elements, elements, Operand(r4, LSL, kPointerSizeLog2 -
kSmiTagSize));
- __ ldr(r0, MemOperand(elements, FixedArray::kHeaderSize -
kHeapObjectTag));
+ __ ldr(r0, FieldMemOperand(elements, FixedArray::kHeaderSize));
__ cmp(r0, r6);
__ b(eq, &call_builtin);
@@ -1738,7 +1738,7 @@
__ str(r4, FieldMemOperand(receiver, JSArray::kLengthOffset));
// Fill with the hole.
- __ str(r6, MemOperand(elements, FixedArray::kHeaderSize -
kHeapObjectTag));
+ __ str(r6, FieldMemOperand(elements, FixedArray::kHeaderSize));
__ Drop(argc + 1);
__ Ret();
=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Tue Mar 27
04:21:27 2012
+++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Mon Apr 2
06:26:05 2012
@@ -2977,7 +2977,7 @@
__ Move(f14, zero_reg, a1);
// Subtract and store the result in the heap number.
__ sub_d(f0, f12, f14);
- __ sdc1(f0, MemOperand(s0, HeapNumber::kValueOffset - kHeapObjectTag));
+ __ sdc1(f0, FieldMemOperand(s0, HeapNumber::kValueOffset));
__ mov(v0, s0);
} else {
__ PrepareCallCFunction(2, a0);
=======================================
--- /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc Mon
Apr 2 04:27:37 2012
+++ /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc Mon
Apr 2 06:26:05 2012
@@ -513,7 +513,7 @@
__ Addu(a0, a0, current_character());
}
- __ lbu(a0, MemOperand(a0, ByteArray::kHeaderSize - kHeapObjectTag));
+ __ lbu(a0, FieldMemOperand(a0, ByteArray::kHeaderSize));
BranchOrBacktrack(on_bit_set, ne, a0, Operand(zero_reg));
}
=======================================
--- /branches/bleeding_edge/src/mips/stub-cache-mips.cc Wed Mar 21 01:41:16
2012
+++ /branches/bleeding_edge/src/mips/stub-cache-mips.cc Mon Apr 2 06:26:05
2012
@@ -1737,14 +1737,14 @@
// expensive shift first, and use an offset later on.
__ sll(t1, t0, kPointerSizeLog2 - kSmiTagSize);
__ Addu(elements, elements, t1);
- __ lw(v0, MemOperand(elements, FixedArray::kHeaderSize -
kHeapObjectTag));
+ __ lw(v0, FieldMemOperand(elements, FixedArray::kHeaderSize));
__ Branch(&call_builtin, eq, v0, Operand(t2));
// Set the array's length.
__ sw(t0, FieldMemOperand(receiver, JSArray::kLengthOffset));
// Fill with the hole.
- __ sw(t2, MemOperand(elements, FixedArray::kHeaderSize -
kHeapObjectTag));
+ __ sw(t2, FieldMemOperand(elements, FixedArray::kHeaderSize));
__ Drop(argc + 1);
__ Ret();
@@ -3496,7 +3496,7 @@
CpuFeatures::Scope scope(FPU);
__ mtc1(value, f0);
__ cvt_d_w(f0, f0);
- __ sdc1(f0, MemOperand(v0, HeapNumber::kValueOffset -
kHeapObjectTag));
+ __ sdc1(f0, FieldMemOperand(v0, HeapNumber::kValueOffset));
__ Ret();
} else {
Register dst1 = t2;
@@ -3544,7 +3544,7 @@
__ Cvt_d_uw(f0, value, f22);
- __ sdc1(f0, MemOperand(v0, HeapNumber::kValueOffset -
kHeapObjectTag));
+ __ sdc1(f0, FieldMemOperand(v0, HeapNumber::kValueOffset));
__ Ret();
} else {
@@ -3598,7 +3598,7 @@
__ AllocateHeapNumber(v0, t3, t5, t6, &slow);
// The float (single) value is already in fpu reg f0 (if we use
float).
__ cvt_d_s(f0, f0);
- __ sdc1(f0, MemOperand(v0, HeapNumber::kValueOffset -
kHeapObjectTag));
+ __ sdc1(f0, FieldMemOperand(v0, HeapNumber::kValueOffset));
__ Ret();
} else {
// Allocate a HeapNumber for the result. Don't use a0 and a1 as
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
