LGTM (with comments addressed).
http://codereview.chromium.org/9965101/diff/5001/src/debug.cc File src/debug.cc (right): http://codereview.chromium.org/9965101/diff/5001/src/debug.cc#newcode782 src/debug.cc:782: // If a stack overflow happened white creating the message object, silently s/white/while/ http://codereview.chromium.org/9965101/diff/5001/src/debug.cc#newcode784 src/debug.cc:784: if (isolate->has_pending_exception()) { Can this actually happen? If not, I would prefer an assertion here instead. http://codereview.chromium.org/9965101/diff/5001/src/execution.cc File src/execution.cc (right): http://codereview.chromium.org/9965101/diff/5001/src/execution.cc#newcode829 src/execution.cc:829: StackLimitCheck check(isolate); As discussed offline, those are just "better-safe-than-sorry" checks. But I am also in favor of keeping them in. http://codereview.chromium.org/9965101/diff/5001/src/execution.cc#newcode870 src/execution.cc:870: StackLimitCheck check(isolate); Likewise. http://codereview.chromium.org/9965101/diff/7001/test/mjsunit/regress/regress-119429.js File test/mjsunit/regress/regress-119429.js (right): http://codereview.chromium.org/9965101/diff/7001/test/mjsunit/regress/regress-119429.js#newcode38 test/mjsunit/regress/regress-119429.js:38: recurse(); Can we use assertThrows("recurse();") instead? http://codereview.chromium.org/9965101/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
