LGTM (with two nits).
https://chromiumcodereview.appspot.com/9903019/diff/10001/src/incremental-marking.cc File src/incremental-marking.cc (right): https://chromiumcodereview.appspot.com/9903019/diff/10001/src/incremental-marking.cc#newcode212 src/incremental-marking.cc:212: ObjectVisitor::VisitSharedFunctionInfo(shared); You don't need that call anymore. https://chromiumcodereview.appspot.com/9903019/diff/10001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/9903019/diff/10001/src/objects.cc#newcode7994 src/objects.cc:7994: void ObjectVisitor::VisitSharedFunctionInfo(SharedFunctionInfo* shared) { You could move that to the header file. https://chromiumcodereview.appspot.com/9903019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
