https://chromiumcodereview.appspot.com/9976003/diff/1/src/frames.cc File src/frames.cc (right):
https://chromiumcodereview.appspot.com/9976003/diff/1/src/frames.cc#newcode1372 src/frames.cc:1372: void Init() { How about putting this directly in SetUpJSCallerSavedCodeData? I don't see the need for the function on the struct any more. https://chromiumcodereview.appspot.com/9976003/diff/1/src/platform-macos.cc File src/platform-macos.cc (right): https://chromiumcodereview.appspot.com/9976003/diff/1/src/platform-macos.cc#newcode881 src/platform-macos.cc:881: } Can you please move these back to where they use to be in the file? It makes the diff shorter and the change more compact. Also applies to other platform files. https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc File src/v8.cc (right): https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc#newcode279 src/v8.cc:279: SamplerRegistry::GlobalSetUp(); nit: Perhaps just SetUp rather than GlobalSetUp, since all of the other methods of the same kind use that convention. https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc#newcode280 src/v8.cc:280: ExternalReference::GlobalSetUp(); Same here https://chromiumcodereview.appspot.com/9976003/diff/1/src/x64/disasm-x64.cc File src/x64/disasm-x64.cc (right): https://chromiumcodereview.appspot.com/9976003/diff/1/src/x64/disasm-x64.cc#newcode348 src/x64/disasm-x64.cc:348: const InstructionTable& instruction_table_; We don't use const references in V8. Please use const *. https://chromiumcodereview.appspot.com/9976003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
