Reviewers: Michael Starzinger,
Description:
Fix stack overflows on Windows x64.
[email protected]
TEST=win 64 not red anymore
Please review this at https://chromiumcodereview.appspot.com/10008005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
M test/mjsunit/regress/regress-119429.js
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
0668addb4885849810e2dd273add694ca68de284..9193cb95c728465e11797b349eb72618d8dba8d4
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -310,7 +310,9 @@ DEFINE_bool(enable_liveedit, true, "enable liveedit
experimental feature")
DEFINE_bool(break_on_abort, true, "always cause a debug break before
aborting")
// execution.cc
-DEFINE_int(stack_size, kPointerSize * 128,
+// Slightly less than 1MB on 64-bit, since Windows' default stack size for
+// the main execution thread is 1MB for both 32 and 64-bit Windows.
+DEFINE_int(stack_size, kPointerSize * 125,
"default size of stack region v8 is allowed to use (in kBytes)")
// frames.cc
Index: test/mjsunit/regress/regress-119429.js
diff --git a/test/mjsunit/regress/regress-119429.js
b/test/mjsunit/regress/regress-119429.js
index
b3a960dfad1eb54079340ded69729b3a00981998..28637966b7b401eef2fa46b14ac415f99adeb32b
100644
--- a/test/mjsunit/regress/regress-119429.js
+++ b/test/mjsunit/regress/regress-119429.js
@@ -29,7 +29,7 @@
var d = 0;
function recurse() {
- if (++d == 26130) { // A magic number just below stack overflow on ia32
+ if (++d == 25515) { // A magic number just below stack overflow on ia32
%DebugBreak();
}
recurse();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
