https://chromiumcodereview.appspot.com/10006032/diff/1/src/list-inl.h File src/list-inl.h (right):
https://chromiumcodereview.appspot.com/10006032/diff/1/src/list-inl.h#newcode237 src/list-inl.h:237: int operator()(const T* elem) { On 2012/04/10 09:30:55, Mikhail Naganov (Chromium) wrote:
Please rename the argument, otherwise it looks like it's somehow
related to the
'elem_' member.
Done. https://chromiumcodereview.appspot.com/10006032/diff/1/src/list.h File src/list.h (right): https://chromiumcodereview.appspot.com/10006032/diff/1/src/list.h#newcode177 src/list.h:177: int SortedListBSearch(const List<T>& list, P cmp); On 2012/04/10 09:30:55, Mikhail Naganov (Chromium) wrote:
I think, some words of comments need to be added about the comparator
functor. Done.
And should it be 'class P' instead of 'typename P'? There is no syntax difference, but you don't expect primitive types as the second
template
argument, do you?
Fixed. In theory it may be a function but this is unlikely. https://chromiumcodereview.appspot.com/10006032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
