Reviewers: Michael Starzinger, Description: Regexp: Fix rightContext in the lastMatchInfoOverride case.
Please review this at https://chromiumcodereview.appspot.com/10071007/ SVN Base: http://v8.googlecode.com/svn/branches/3.7/ Affected files: M src/regexp.js M src/version.cc A test/mjsunit/regexp-capture-3.js Index: src/regexp.js =================================================================== --- src/regexp.js (revision 11284) +++ src/regexp.js (working copy) @@ -347,7 +347,8 @@ } else { var override = lastMatchInfoOverride; subject = override[override.length - 1]; - start_index = override[override.length - 2] + subject.length; + var pattern = override[override.length - 3]; + start_index = override[override.length - 2] + pattern.length; } return SubString(subject, start_index, subject.length); } Index: src/version.cc =================================================================== --- src/version.cc (revision 11284) +++ src/version.cc (working copy) @@ -35,7 +35,7 @@ #define MAJOR_VERSION 3 #define MINOR_VERSION 7 #define BUILD_NUMBER 12 -#define PATCH_LEVEL 32 +#define PATCH_LEVEL 33 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) #define IS_CANDIDATE_VERSION 0 Index: test/mjsunit/regexp-capture-3.js =================================================================== --- test/mjsunit/regexp-capture-3.js (revision 0) +++ test/mjsunit/regexp-capture-3.js (revision 0) @@ -0,0 +1,30 @@ +// Copyright 2012 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +"abcd".replace(/b/g, function() { }); + +assertEquals("cd", RegExp.rightContext); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
