LGTM.
https://chromiumcodereview.appspot.com/10010046/diff/2001/src/scopes.cc File src/scopes.cc (right): https://chromiumcodereview.appspot.com/10010046/diff/2001/src/scopes.cc#newcode955 src/scopes.cc:955: // We found a variable variable binding that might be shadowed Only one "variable". https://chromiumcodereview.appspot.com/10010046/diff/2001/src/scopes.cc#newcode959 src/scopes.cc:959: } else if (var->is_dynamic()) { This is kind of subtle and doesn't jive with the comment above that we found a binding. Maybe we need some explanation: "we didn't find binding but we found a scope where we gave up looking for a binding, so we have to give up here, too"? https://chromiumcodereview.appspot.com/10010046/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
