LGTM with comments

https://chromiumcodereview.appspot.com/10008082/diff/1001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10008082/diff/1001/build/common.gypi#newcode286
build/common.gypi:286: 'm32flag': '<!((echo | $(echo ${CXX:-$(which
g++)}) -m32 -E - >/dev/null 2>&1) && echo -n "-m32" || echo -n "")',
nit: 80 col? and maybe Sven's || true suggestion?

https://chromiumcodereview.appspot.com/10008082/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to