Thanks for the review, I updated the CL based on your suggestion.
http://codereview.chromium.org/10083001/diff/1/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc (right): http://codereview.chromium.org/10083001/diff/1/src/mips/stub-cache-mips.cc#newcode1362 src/mips/stub-cache-mips.cc:1362: __ Push(receiver, holder_reg); On 2012/04/13 11:41:50, Michael Starzinger wrote:
For MIPS this whole if-else-block seems to be unnecessary. Can we just
use "__
Push(receiver, holder_reg)" instead of lines 1357 to 1363?
Done. Not sure how I missed this. http://codereview.chromium.org/10083001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
