LGTM (just a few nits).
https://chromiumcodereview.appspot.com/10067010/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10067010/diff/1/src/runtime.cc#newcode1344 src/runtime.cc:1344: // If the local property exists, check that we can either reconfigure it This sentences is missing the "or" part of "either ... or" I think. https://chromiumcodereview.appspot.com/10067010/diff/1/src/runtime.cc#newcode1496 src/runtime.cc:1496: /*ERRATUM: no longer need to traverse the prototype chain?*/ This looks like a leftover, should that be a TODO? https://chromiumcodereview.appspot.com/10067010/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/10067010/diff/1/test/cctest/test-api.cc#newcode12433 test/cctest/test-api.cc:12433: // value does not shadow an existing property in the prototype chain. The whole comment no longer applies. https://chromiumcodereview.appspot.com/10067010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
