LGTM
http://codereview.chromium.org/9969196/diff/1/test/cctest/test-strings.cc File test/cctest/test-strings.cc (right): http://codereview.chromium.org/9969196/diff/1/test/cctest/test-strings.cc#newcode634 test/cctest/test-strings.cc:634: CompileRun("%_SubString('abcdef', 5, 2)"); I'd like more tests here. Negative numbers, borderline numbers, heap numbers, input strings large enough to trigger the creation of SlicedStrings, slices of slices where the args are out of bounds for the slice, but not for the underlying string. http://codereview.chromium.org/9969196/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
