LGTM (with nits).
http://codereview.chromium.org/10091027/diff/1004/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/10091027/diff/1004/src/heap.cc#newcode1390 src/heap.cc:1390: // Note that write barrier has not effect if we are already the middle of Missing "in" and s/not/no/ http://codereview.chromium.org/10091027/diff/1004/src/objects-visiting.h File src/objects-visiting.h (right): http://codereview.chromium.org/10091027/diff/1004/src/objects-visiting.h#newcode296 src/objects-visiting.h:296: HeapObject::RawField(object, JSFunction::kCodeEntryOffset)); Can we put a comment here saying that we don't visit the code entry slot because it will always point to old-space or something like that? http://codereview.chromium.org/10091027/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
