[v8-dev] Fix mod on ia32 without SSE2. (issue 10128004)

Thu, 19 Apr 2012 02:30:30 -0700 

Reviewers: Vyacheslav Egorov,

Description:
Fix mod on ia32 without SSE2.


Please review this at http://codereview.chromium.org/10128004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/ia32/code-stubs-ia32.cc


Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index 229e8fc536599476abb765d3f82835cab8a3e455..6cd02338977eb0e5086375074b8e24bbef8786f3 100644 
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -1734,6 +1734,9 @@ void BinaryOpStub::GenerateInt32Stub(MacroAssembler* masm) { 
             FloatingPointHelper::ARGS_IN_REGISTERS);
         FloatingPointHelper::CheckFloatOperandsAreInt32(masm, &not_int32);
         if (op_ == Token::MOD) {
+          // The operands are now on the FPU stack, but we don't need them.
+          __ fstp(0);
+          __ fstp(0);
           GenerateRegisterArgsPush(masm);
           __ InvokeBuiltin(Builtins::MOD, JUMP_FUNCTION);
         } else {


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to