Revision: 11384 Author: [email protected] Date: Thu Apr 19 03:28:26 2012 Log: Fix presubmit check for the case when cpplint fails.
BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10124006 http://code.google.com/p/v8/source/detail?r=11384 Modified: /branches/bleeding_edge/tools/presubmit.py ======================================= --- /branches/bleeding_edge/tools/presubmit.py Fri Jan 20 08:17:08 2012 +++ /branches/bleeding_edge/tools/presubmit.py Thu Apr 19 03:28:26 2012 @@ -114,12 +114,15 @@ while True: out_line = process.stderr.readline() if out_line == '' and process.poll() != None: + if error_count == -1: + print "Failed to process %s" % command.pop() + return 1 break m = LINT_OUTPUT_PATTERN.match(out_line) if m: out_lines += out_line error_count += 1 - sys.stderr.write(out_lines) + sys.stdout.write(out_lines) return error_count except KeyboardInterrupt: process.kill() -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
