Thanks for your comments. PTAL.
https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator.h File src/profile-generator.h (right): https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator.h#newcode1028 src/profile-generator.h:1028: const char* GetGcSubrootName(Object* object); On 2012/04/19 13:52:29, Mikhail Naganov (Chromium) wrote:
If it deals only with strong roots, perhaps call it
'GetStrongGcSubrootName'? Done. https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator.h#newcode1043 src/profile-generator.h:1043: HashMap gc_subroot_names_; On 2012/04/19 13:52:29, Mikhail Naganov (Chromium) wrote:
Why are you using a generic HashMap? HeapObjectsSet can associate heap
objects
with tags.
Done. https://chromiumcodereview.appspot.com/10128006/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/10128006/diff/1/test/cctest/test-heap-profiler.cc#newcode13 test/cctest/test-heap-profiler.cc:13: #include <ctype.h> On 2012/04/19 13:52:29, Mikhail Naganov (Chromium) wrote:
System headers must go before project headers:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_and_Order_of_Includes#Names_and_Order_of_Includes Done. https://chromiumcodereview.appspot.com/10128006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
