LGTM. If that (temporary) fixes all the WebKit failures.
https://chromiumcodereview.appspot.com/10163003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/10163003/diff/1/src/flag-definitions.h#newcode135 src/flag-definitions.h:135: DEFINE_bool(es52_globals, false, "activate new semantics for global var declarations") Longer than 80 characters. https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-api.cc#newcode12486 test/cctest/test-api.cc:12486: v8::internal::FLAG_es52_globals = true; Can we just use "i::FLAG_es52_globals"? https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-decls.cc File test/cctest/test-decls.cc (right): https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-decls.cc#newcode524 test/cctest/test-decls.cc:524: v8::internal::FLAG_es52_globals = true; Likewise. https://chromiumcodereview.appspot.com/10163003/diff/1/test/cctest/test-decls.cc#newcode587 test/cctest/test-decls.cc:587: v8::internal::FLAG_es52_globals = true; Likewise. https://chromiumcodereview.appspot.com/10163003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
