LGTM
https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc#newcode2099 src/profile-generator.cc:2099: TagObject(shared->unchecked_code(), "(code)"); I think, SFI doesn't always contain compiled code. https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc#newcode2117 src/profile-generator.cc:2117: SetInternalReference(obj, entry, On 2012/04/20 13:14:08, Yury Semikhatsky wrote:
Would be nice to be able to validate that we capture all essential
links in the
snapshots and don't miss things like these.
We always capture all links -- after adding named links we run IndexedReferencesExtractor to extract all remaining references. These lines are only for setting names of references that we know about. https://chromiumcodereview.appspot.com/10169007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
