Reviewers: mstarzinger_chromium-.org, Description: Remove unused IsNan function
Please review this at http://codereview.chromium.org/10167008/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/double.h M test/cctest/test-double.cc Index: src/double.h =================================================================== --- src/double.h (revision 11404) +++ src/double.h (working copy) @@ -130,12 +130,6 @@ return (d64 & kExponentMask) == kExponentMask; } - bool IsNan() const { - uint64_t d64 = AsUint64(); - return ((d64 & kExponentMask) == kExponentMask) && - ((d64 & kSignificandMask) != 0); - } - bool IsInfinite() const { uint64_t d64 = AsUint64(); return ((d64 & kExponentMask) == kExponentMask) && Index: test/cctest/test-double.cc =================================================================== --- test/cctest/test-double.cc (revision 11404) +++ test/cctest/test-double.cc (working copy) @@ -112,21 +112,6 @@ } -TEST(IsNan) { - CHECK(Double(OS::nan_value()).IsNan()); - uint64_t other_nan = V8_2PART_UINT64_C(0xFFFFFFFF, 00000001); - CHECK(Double(other_nan).IsNan()); - CHECK(!Double(V8_INFINITY).IsNan()); - CHECK(!Double(-V8_INFINITY).IsNan()); - CHECK(!Double(0.0).IsNan()); - CHECK(!Double(-0.0).IsNan()); - CHECK(!Double(1.0).IsNan()); - CHECK(!Double(-1.0).IsNan()); - uint64_t min_double64 = V8_2PART_UINT64_C(0x00000000, 00000001); - CHECK(!Double(min_double64).IsNan()); -} - - TEST(Sign) { CHECK_EQ(1, Double(1.0).Sign()); CHECK_EQ(1, Double(V8_INFINITY).Sign()); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
