Revision: 11415
Author: erikcorry
Date: Mon Apr 23 06:44:06 2012
Log: Remove unused IsNan function
Review URL: http://codereview.chromium.org/10167008
http://code.google.com/p/v8/source/detail?r=11415
Modified:
/branches/bleeding_edge/src/double.h
/branches/bleeding_edge/test/cctest/test-double.cc
=======================================
--- /branches/bleeding_edge/src/double.h Tue Nov 29 02:56:11 2011
+++ /branches/bleeding_edge/src/double.h Mon Apr 23 06:44:06 2012
@@ -129,12 +129,6 @@
uint64_t d64 = AsUint64();
return (d64 & kExponentMask) == kExponentMask;
}
-
- bool IsNan() const {
- uint64_t d64 = AsUint64();
- return ((d64 & kExponentMask) == kExponentMask) &&
- ((d64 & kSignificandMask) != 0);
- }
bool IsInfinite() const {
uint64_t d64 = AsUint64();
=======================================
--- /branches/bleeding_edge/test/cctest/test-double.cc Tue Dec 7 03:01:02
2010
+++ /branches/bleeding_edge/test/cctest/test-double.cc Mon Apr 23 06:44:06
2012
@@ -110,21 +110,6 @@
uint64_t min_double64 = V8_2PART_UINT64_C(0x00000000, 00000001);
CHECK(!Double(min_double64).IsInfinite());
}
-
-
-TEST(IsNan) {
- CHECK(Double(OS::nan_value()).IsNan());
- uint64_t other_nan = V8_2PART_UINT64_C(0xFFFFFFFF, 00000001);
- CHECK(Double(other_nan).IsNan());
- CHECK(!Double(V8_INFINITY).IsNan());
- CHECK(!Double(-V8_INFINITY).IsNan());
- CHECK(!Double(0.0).IsNan());
- CHECK(!Double(-0.0).IsNan());
- CHECK(!Double(1.0).IsNan());
- CHECK(!Double(-1.0).IsNan());
- uint64_t min_double64 = V8_2PART_UINT64_C(0x00000000, 00000001);
- CHECK(!Double(min_double64).IsNan());
-}
TEST(Sign) {
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev