https://chromiumcodereview.appspot.com/10184004/diff/1/src/macros.py File src/macros.py (right):
https://chromiumcodereview.appspot.com/10184004/diff/1/src/macros.py#newcode199 src/macros.py:199: macro LAST_SUBJECT(array) = ((array)[1]); On 2012/04/23 16:59:23, ulan wrote:
We can avoid duplication: macro LAST_SUBJECT(array) = ((array)[LAST_SUBJECT_INDEX]);
Done. https://chromiumcodereview.appspot.com/10184004/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10184004/diff/1/src/runtime.cc#newcode2885 src/runtime.cc:2885: static void SetLastMatchInfoNoCaptures(Handle<String> subject, On 2012/04/23 16:59:23, ulan wrote:
Why not just move the implementation here, instead of forward
declaration? Because then it would be hard to review. Done. https://chromiumcodereview.appspot.com/10184004/diff/1/src/string.js File src/string.js (right): https://chromiumcodereview.appspot.com/10184004/diff/1/src/string.js#newcode246 src/string.js:246: // We use this hack to detect whether StringReplaceRegExpWithString found On 2012/04/23 16:59:23, ulan wrote:
Long line
Done. https://chromiumcodereview.appspot.com/10184004/diff/1/src/string.js#newcode249 src/string.js:249: lastMatchInfo[LAST_SUBJECT_INDEX] = 0; On 2012/04/23 16:59:23, ulan wrote:
This is sad, but I don't see a better way.
Me neither. https://chromiumcodereview.appspot.com/10184004/diff/1/src/string.js#newcode461 src/string.js:461: for ( ; i < len; i++) { On 2012/04/23 16:59:23, ulan wrote:
Can we make i local in the loop?
Well not really. This is JS, after all. But we can pretend. https://chromiumcodereview.appspot.com/10184004/diff/1/src/string.js#newcode487 src/string.js:487: for ( ; i < len; i++) { On 2012/04/23 16:59:23, ulan wrote:
Can we make i local in the loop?
As above. https://chromiumcodereview.appspot.com/10184004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
