https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.cc#newcode1975 src/profile-generator.cc:1975: void V8HeapExplorer::ExtractJSGlobalProxy(JSGlobalProxy* proxy) { I think you should put these functions after ExtractReferences, so first you see the top-level function, and then its helpers. https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.h File src/profile-generator.h (right): https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.h#newcode988 src/profile-generator.h:988: nit: Why blank line? https://chromiumcodereview.appspot.com/10198011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
