LGTM (with a few nits).
https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcode1563 src/hydrogen.cc:1563: for (int bit = 0; bit < 31; ++bit) { Better use "kAfterLastFlag" instead of "31" here. https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcode1572 src/hydrogen.cc:1572: bool positive_changes = set_changes < 8; It would also be nice if "8" would somehow be based on the number of GVN flags. Currently "set_changes <= kAfterLastFlag / 4" would probably do the trick. But I don't know if that is less hacky. https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcode1580 src/hydrogen.cc:1580: for (int bit = 0; bit < 31; ++bit) { Likewise. https://chromiumcodereview.appspot.com/10203010/diff/1/src/hydrogen.cc#newcode1609 src/hydrogen.cc:1609: for (int bit = 0; bit < 31; ++bit) { Likewise. https://chromiumcodereview.appspot.com/10203010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
