https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js File src/mirror-debugger.js (right):
https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js#newcode600 src/mirror-debugger.js:600: * Return the primitive value if this is object of Boolean, Number or String type (but not Date). On 2012/04/17 12:48:44, Yang wrote:
Please keep the 80 character limit.
Sorry, too much programming in WebKit :) https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js#newcode604 src/mirror-debugger.js:604: if (!IS_STRING_WRAPPER(this.value_) && !IS_NUMBER_WRAPPER(this.value_) && !IS_BOOLEAN_WRAPPER(this.value_)) { On 2012/04/17 12:48:44, Yang wrote:
Ditto.
Done. https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc#newcode12287 src/runtime.cc:12287: } On 2012/04/17 12:48:44, Yang wrote:
This seems to do the same as %_ValueOf (see
FullCodeGenerator::EmitValueOf). Done. https://chromiumcodereview.appspot.com/10091022/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
