On 2012/04/17 14:32:43, Yang wrote:
On 2012/04/17 14:25:01, Net147 wrote: >
https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc
> File test/cctest/test-disasm-x64.cc (right): > >
https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc#newcode267
> test/cctest/test-disasm-x64.cc:267: (void) after_break_target; > On 2012/04/17 13:37:19, Yang wrote: > > What is this for? > > I get a compiler error because it thinks this variable is never used.
Unfortunately, this sort of cast violates the Google code style: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Casting
Maybe you can take advantage of the USE(x) template in globals.h?
Updated. https://chromiumcodereview.appspot.com/10019012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
