Reviewers: Yang,
Message:
V8 LiveEdit implementation requires client to manually issue "step in"
command.
This requirement is considered implementation-specific so we have to
explicitly
manifest it to client.
Currently "step_in_recommended" is added at the V8 debug protocol level, but
WebKit omits this level and accesses Debug.LiveEdit.SetScriptSource
directly. We
should add this flag to its result too so that WebKit knew when to
issue "step
in" command.
Description:
Add "step in recommended" to LiveEdit response object.
Please review this at https://chromiumcodereview.appspot.com/10185006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/liveedit-debugger.js
Index: src/liveedit-debugger.js
diff --git a/src/liveedit-debugger.js b/src/liveedit-debugger.js
index
abfb0f69c61bd7a9dadbe45cd2cfb6749b358fdf..4463c93e2a071acafc2b0ff482d25ceb53f57abb
100644
--- a/src/liveedit-debugger.js
+++ b/src/liveedit-debugger.js
@@ -159,6 +159,11 @@ Debug.LiveEdit = new function() {
preview_description.stack_modified = dropped_functions_number != 0;
+ // Our current implementation requires client to manually issue "step
in"
+ // command for correct stack state.
+ preview_description.stack_update_needs_step_in =
+ preview_description.stack_modified;
+
// Start with breakpoints. Convert their line/column positions and
// temporary remove.
var break_points_restorer = TemporaryRemoveBreakPoints(script,
change_log);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
