LGTM. Just a little general remark: With every single change like this we
say a
little bit more "goodbye" to linking v8 dynamically, because we lose more
and
more binary compatibility. But I guess this was never a design goal...
https://chromiumcodereview.appspot.com/10199019/diff/1/src/api.cc
File src/api.cc (right):
https://chromiumcodereview.appspot.com/10199019/diff/1/src/api.cc#newcode4633
src/api.cc:4633: if (!EnsureInitializedForIsolate(isolate,
"v8::String::Empty()")) {
Just out of curiosity: Why do we need this change? Or asked another way:
Why do we *not* need it in tons of other places? Or should we test the
result of EnusreInitializedForIsolate everywhere? api.cc is extremely
inconsistent...
https://chromiumcodereview.appspot.com/10199019/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
