LGTM (with one comment).
https://chromiumcodereview.appspot.com/10173023/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10173023/diff/1/src/hydrogen.cc#newcode1634 src/hydrogen.cc:1634: if (string_len > sizeof(underlying_buffer)) { I think this condition can never be true. Can we drop this block (or at least make it an assertion)? https://chromiumcodereview.appspot.com/10173023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
