On 2012/04/25 22:59:27, Peter Rybin wrote:
> Could you please add more tests that exercise different combinations of
stack
> allocated and context allocated variables? And also tests with "let"
variables
> (this requires --harmony flag and "use strict").
I added several more test cases. I don't know how to properly prepare test
with
"--harmony" flag enabled, but I tried it manually.
I think we shouldn't really try all possible scope combinations, because
there
is no new code submitted about it. It only reuses the standard code for
scopes.
You can add flags at the begin of a .js test file following "// Flags: ",
the
way it's already being done in debug-function-scopes.js. While you are at
this,
you can also remove the --allow-natives-syntax flag since it's not
necessary.
https://chromiumcodereview.appspot.com/10171003/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
