LGTM with comments
http://codereview.chromium.org/10134057/diff/1/src/string.js File src/string.js (right): http://codereview.chromium.org/10134057/diff/1/src/string.js#newcode400 src/string.js:400: // ReplaceResultBuilder Comment out of date http://codereview.chromium.org/10134057/diff/1/src/string.js#newcode406 src/string.js:406: if (start < 0) return; This return seems wrong. Should we not return a string? The tests need beefing up to catch this. http://codereview.chromium.org/10134057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
