Reviewers: Michael Starzinger, Description: Fix spurious bugs in GrowAndShrinkNewSpace when the min and max new space sizes are equal.
Please review this at https://chromiumcodereview.appspot.com/10241002/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/test-heap.cc Index: test/cctest/test-heap.cc =================================================================== --- test/cctest/test-heap.cc (revision 11455) +++ test/cctest/test-heap.cc (working copy) @@ -1275,6 +1275,12 @@ InitializeVM(); NewSpace* new_space = HEAP->new_space(); + if (HEAP->ReservedSemiSpaceSize() == HEAP->InitialSemiSpaceSize()) { + // We can't test new space growing and shrinking if the max size + // is the same as the minimum (initial) size. + return; + } + // Explicitly growing should double the space capacity. intptr_t old_capacity, new_capacity; old_capacity = new_space->Capacity(); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
