lgtm



https://chromiumcodereview.appspot.com/10235006/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://chromiumcodereview.appspot.com/10235006/diff/1/src/code-stubs.cc#newcode121
src/code-stubs.cc:121: RecordCodeGeneration(*new_object, &masm);
I think more logical would be to move code->set_major_key(MajorKey());
out of RecordCodeGeneration to here and then move RecordCodeGeneration
down after FinishCode.

Recording generation of unfinished code looks strange.

https://chromiumcodereview.appspot.com/10235006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to