LGTM with comments.
https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/full-codegen-ia32.cc#newcode4139 src/ia32/full-codegen-ia32.cc:4139: __ mov(ecx, eax); // Key. This is similar to line 1176, except that eax gets overwritten. Why the difference? https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/ic-ia32.cc#newcode525 src/ia32/ic-ia32.cc:525: __ bind(&ok); Can be shortened with MacroAssembler::Check(Condition cc, const char* msg) https://chromiumcodereview.appspot.com/10254005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
