Reviewers: danno,
Message:
Please take a look.
Description:
One more register change missing from r11460.
Also re-enable disabled test (reverts r11461).
BUG=2108
TEST=mozilla tests pass
Please review this at http://codereview.chromium.org/10178039/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/stub-cache-ia32.cc
M test/mozilla/mozilla.status
Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index
d86fe3f1fe991e16698115ab541cbf50e2b7b8cc..46de6a4fc1b8b527851d7eae0add0a025680d077
100644
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -2885,7 +2885,7 @@ Handle<Code>
KeyedLoadStubCompiler::CompileLoadField(Handle<String> name,
__ cmp(ecx, Immediate(name));
__ j(not_equal, &miss);
- GenerateLoadField(receiver, holder, edx, ebx, ecx, edi, index, name,
&miss);
+ GenerateLoadField(receiver, holder, edx, ebx, eax, edi, index, name,
&miss);
__ bind(&miss);
__ DecrementCounter(counters->keyed_load_field(), 1);
Index: test/mozilla/mozilla.status
diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status
index
94435efddff1848a7fd0c01b4c6dc9f50ee4a7ed..c30be5e095002207dfe3997dd444e840d9cac639
100644
--- a/test/mozilla/mozilla.status
+++ b/test/mozilla/mozilla.status
@@ -72,9 +72,6 @@ js1_2/function/Number: SKIP
# TODO(2018): Temporarily allow timeout in debug mode.
js1_5/GC/regress-203278-2: PASS || TIMEOUT if $mode == debug
-# TODO(2108): r11460 made this crash.
-js1_5/Regress/regress-346801: SKIP
-
##################### SLOW TESTS #####################
# This takes a long time to run (~100 seconds). It should only be run
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
