LGTM with nits.
https://chromiumcodereview.appspot.com/10268010/diff/5001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10268010/diff/5001/build/common.gypi#newcode177 build/common.gypi:177: 'mipscompiler': '<!($(echo ${CXX:-$(which g++)}) -v 2>&1 | grep -q "^Target: mips" && echo "yes" || echo "no")', Nit: mips => mips- https://chromiumcodereview.appspot.com/10268010/diff/5001/build/gyp_v8 File build/gyp_v8 (right): https://chromiumcodereview.appspot.com/10268010/diff/5001/build/gyp_v8#newcode172 build/gyp_v8:172: gyp_args.append('-S-x64') -x64 => .x64, same below https://chromiumcodereview.appspot.com/10268010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
