Addressed comments. Rebased. Landed.
https://chromiumcodereview.appspot.com/10263008/diff/12001/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): https://chromiumcodereview.appspot.com/10263008/diff/12001/src/arm/ic-arm.cc#newcode1732 src/arm/ic-arm.cc:1732: // This is patching a conditional "jump if/if-not smi" site. On 2012/05/02 11:29:48, Vyacheslav Egorov wrote:
I think to align with code snippets below this should be jump if not
smi/jump if
smi.
Done. https://chromiumcodereview.appspot.com/10263008/diff/12001/src/x64/ic-x64.cc File src/x64/ic-x64.cc (right): https://chromiumcodereview.appspot.com/10263008/diff/12001/src/x64/ic-x64.cc#newcode1770 src/x64/ic-x64.cc:1770: // short jump-if-carry/not-carry at this position. On 2012/05/02 11:29:48, Vyacheslav Egorov wrote:
Please update the comment just like in ia32
Done. https://chromiumcodereview.appspot.com/10263008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
