LGTM (with once comment).
https://chromiumcodereview.appspot.com/10238005/diff/5002/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10238005/diff/5002/src/objects.cc#newcode4420 src/objects.cc:4420: // accessors, not for the addition of each part. It would really be nice to preserve this assertion somehow. In my understanding the correct place to put it would be at the beginning of DefinePropertyAccessor(). Unfortunately we don't have a lookup result there. Maybe you could come up with some nifty way to check that assertion there. Otherwise a comment there might be useful. https://chromiumcodereview.appspot.com/10238005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
