OK, I looked through the CL again. So basically the switch is just a
conservative estimate to detect all lookup results that are real properties
for
sure. And what you added is that MAP_TRANSITIONs (which are transitions for
sure) will cause a deopt instead of forcing a generic LoadIC. I get it now.
LGTM. Sorry for the confusion.
https://chromiumcodereview.appspot.com/10306010/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/10306010/diff/1/src/hydrogen-instructions.cc#newcode1630
src/hydrogen-instructions.cc:1630: // operation.
In this case, this comment should contain something like "... and
possibly deoptimize in these cases".
https://chromiumcodereview.appspot.com/10306010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
