Revision: 11524
Author: [email protected]
Date: Tue May 8 02:22:58 2012
Log: Make DeltaBlue performance more stable by ignoring type feedback
that
tells us that a map can transition to another map when we are generating
code for load operations. This may cause us to deopt if the same routine
is seeing different maps caused by branching in constructors. If so, I
have a different change that is around 100 times more complicated that
lets us generated Crankshaft code for negative lookups.
Review URL: https://chromiumcodereview.appspot.com/10306010
http://code.google.com/p/v8/source/detail?r=11524
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Wed Apr 25
07:32:27 2012
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Tue May 8
02:22:58 2012
@@ -1603,6 +1603,7 @@
SetOperandAt(1, object);
set_representation(Representation::Tagged());
SetGVNFlag(kDependsOnMaps);
+ int map_transitions = 0;
for (int i = 0;
i < types->length() && types_.length() < kMaxLoadPolymorphism;
++i) {
@@ -1624,13 +1625,20 @@
case CONSTANT_FUNCTION:
types_.Add(types->at(i));
break;
+ case MAP_TRANSITION:
+ // We should just ignore these since they are not relevant to a
load
+ // operation. This means we will deopt if we actually see this
map
+ // from optimized code.
+ map_transitions++;
+ break;
default:
break;
}
}
}
- if (types_.length() == types->length() &&
FLAG_deoptimize_uncommon_cases) {
+ if (types_.length() + map_transitions == types->length() &&
+ FLAG_deoptimize_uncommon_cases) {
SetFlag(kUseGVN);
} else {
SetAllSideEffects();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
