https://chromiumcodereview.appspot.com/10270032/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/10270032/diff/1/src/hydrogen.cc#newcode5717 src/hydrogen.cc:5717: InliningAstSize(expr->target()), On 2012/05/02 08:10:35, Michael Starzinger wrote:
Could we just use "expr->target()->shared()->ast_node_count()" and
disregard
whether we potentially inline the target or not? That would simplify
the code.
Also inlining decision is affected by other factors as well.
The reason I don't do this is that we already have code in place to try to avoid parsing up the function in the case where it is very large. I don't want to duplicate that logic to avoid parsing up the function just in order to sort it. https://chromiumcodereview.appspot.com/10270032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
