https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2294 src/ia32/lithium-codegen-ia32.cc:2294: if (map_count != 0) { On 2012/05/10 13:06:01, Michael Starzinger wrote:
It seems as if this condition always holds, otherwise you would have
ended up in
the IC case. Can we replace this with an ASSERT(map_count != 0)?
No, there are two conditions to get into the IC case now. https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2307 src/ia32/lithium-codegen-ia32.cc:2307: if (map_count != 0) { On 2012/05/10 13:06:01, Michael Starzinger wrote:
Then it makes sense to turn this into an "else if" which would
simplify the
structure.
Same objection. https://chromiumcodereview.appspot.com/10382102/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
