Tabs in the Makefile are fine, as they're required by standard Makefile
syntax.
Please use only one tab at the beginning of the line, then spaces as
necessary
for additional indentation.
However, I don't like all the duplication this CL introduces. Can you
refactor
the existing android.gypi so that it supports both ARM and x86 targets?
Most of
the definitions are the same anyway, and the rest should be able to be
parameterized. Have a look at http://code.google.com/p/gyp/w/list to learn
more
about how to put conditional stuff into GYP files.
My goal would be to have a single "android" make target that takes a
"v8_target_arch" parameter to specify the architecture. Or something along
those
lines.
I can have a stab at this myself, but that'd be at the end of next week at
the
earliest. For this, it would be helpful if you could give me specific
instructions how to setup the toolchain for Android-x86 (which we should put
into the V8 wiki anyway once we have support for this). Is it simply
"make-standalone-toolchain.sh --arch=x86" and everything else is the same
as for
ARM?
Another note: the entire build/android.gypi file is somewhat experimental.
I'm
sure some of the definitions in there are not needed, and the overall
structure
could probably be improved. I'd be interested in suggestions, if you have
any.
http://codereview.chromium.org/10382121/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
