Reviewers: Erik Corry,

Message:
PTAL.

This CL is far from being completed since platform ports and tests are missing.
I still want to get a second opinion on this before I continue.

I implemented the loop inside GetCode() that deals with setting up local
variables and returning results. I initially thought about doing it in a higher level way, representing the loop as a RegExpNode, but then changes to Fail() and
Succeed() were also necessary, so I chose doing it in low-level assembly
instead. Suggestions on that are very welcome.

Description:
Implement loop for global regexps in regexp assembler.

BUG=
TEST=


Please review this at http://codereview.chromium.org/10386090/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/ia32/code-stubs-ia32.cc
  M src/ia32/regexp-macro-assembler-ia32.h
  M src/ia32/regexp-macro-assembler-ia32.cc
  M src/ia32/simulator-ia32.h
  M src/jsregexp.h
  M src/jsregexp.cc
  M src/regexp-macro-assembler-tracer.cc
  M src/regexp-macro-assembler.h
  M src/regexp-macro-assembler.cc
  M src/runtime.cc
  M test/cctest/test-regexp.cc


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to